Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: add --config-file=PATH argument #5082

Merged
merged 2 commits into from
Dec 13, 2024
Merged

cli: add --config-file=PATH argument #5082

merged 2 commits into from
Dec 13, 2024

Conversation

yuja
Copy link
Collaborator

@yuja yuja commented Dec 12, 2024

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

yuja added 2 commits December 12, 2024 21:01
@yuja
cli: set global args to config table without re-parsing as TOML
b213d0f 
This should be safer than constructing a parsable TOML form.
@yuja
cli: add --config-file=PATH argument
9293da8 
This would be useful for scripting purpose. Maybe we can also replace the
current --config-toml=<TOML> use cases by --config-file=<PATH> and simpler
--config=<KEY>=<VALUE>.

martinvonz#4926 (comment)

If we want to add more source variants (such as fd number), it might be better
to add --config-from=<type>:<path|fd|..>. In any case, we'll probably want
--config=<KEY>=<VALUE>, and therefore, we'll need to merge more than one
--config* arguments.
PhilipMetzger
PhilipMetzger approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@PhilipMetzger PhilipMetzger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Yuya.

If we want to add more source variants (such as fd number), it might be better
to add --config-from=:<path|fd|..>.

This also seems like a really good idea.

@yuja
Copy link
Collaborator Author

yuja commented Dec 13, 2024

If we want to add more source variants (such as fd number), it might be better
to add --config-from=:<path|fd|..>.

This also seems like a really good idea.

I'm not yet sure if we'll add some of these, so I'll take --config-file=PATH syntax for now.

@yuja yuja merged commit fca92f1 into martinvonz:main Dec 13, 2024
18 checks passed
@yuja yuja deleted the push-uwoqxxsuntvr branch December 13, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilipMetzger PhilipMetzger PhilipMetzger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuja @PhilipMetzger