Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

templates: align attributes in builtin_log_detailed #5046

Merged
merged 1 commit into from
Dec 8, 2024

Conversation

avamsi
Copy link
Collaborator

@avamsi avamsi commented Dec 7, 2024

Commit ID, Change ID, Bookmarks and Committer all align perfectly apart from Tags and Author.
Figured I'd check if anyone is sympathetic to this.. :)

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

Change-Id: Id00000003feb0508bf7f08e0a0275ba7f7695b70
@avamsi avamsi force-pushed the av/jj_wklozuzroksk branch from a1c4dcf to d813ae2 Compare December 7, 2024 17:24
Copy link
Collaborator

@yuja yuja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with either way, but it seems nice that author and committer fields are aligned.

@avamsi avamsi merged commit 0794f87 into martinvonz:main Dec 8, 2024
18 checks passed
@avamsi avamsi deleted the av/jj_wklozuzroksk branch December 8, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants