completion: teach jj about aliases #4832
Merged
+83
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senekor
force-pushed
the
remo/complete-aliases
branch
from
79181fb to
c8ad0ea
Compare
senekor
commented
Nov 11, 2024
|
Re commit descriptions: at a glance, it's hard to tell how "teach jj about alias" is different from "resolve aliases" from 325402d . I'm sure it'd be clearer if I read the code, but I'd still appreciate a short explanation in the description (assuming this PR indeed does something different). |
senekor
force-pushed
the
remo/complete-aliases
branch
from
c8ad0ea to
d950f8f
Compare
|
I added an explanation to the description, let me know if it can still be improved. |
senekor
force-pushed
the
remo/complete-aliases
branch
5 times, most recently
from
dc463af to
d33fbec
Compare
martinvonz
approved these changes
Nov 14, 2024
This makes completions suggest aliases from the user or repository configuration. It's more useful for long aliases that aren't used very often, but serve the purpose of "executable documentation" of complex and useful jj commands. An earlier patch "resolved" aliases, meaning that any arguments following an alias would be completed as if the normal command had been used. So it only made sure that using aliases doesn't degrade the rest of the completions. Commit ID: 325402d
senekor
force-pushed
the
remo/complete-aliases
branch
from
d33fbec to
1192a46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.md