describe: warn user of limitations of describing multiple commits interface #4211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions This seems especially helpful if the descriptions start out empty.
yuja
approved these changes
Aug 5, 2024
ilyagr
force-pushed
the
warn
branch
4 times, most recently
from
77b6bd2 to
83bba79
Compare
I think it might be nice to have this in the upcoming release, but I'd like to warn people that their changes will be lost if they aren't careful, and to not rely on the syntax being fixed just yet.
ilyagr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows up on #3828, cc @bnjmnt4n (and thanks again for implementing this!). It also includes an additional line of explanation.
Calling this an "experimental feature" seems appropriate to me, but let me know if this feels excessive.
I don't think we will or should try to fix all the slightly rough edges by the Wednesday release.
Ultimately, I wonder if we can make this work smoothly with some form of
rebase --interactive, including things like squashing and reordering commits.Update: I also added a third commit with a new test. This ended up leading me to add
op restoreto the existing tests as well. Let me know if this should be a separate discussion in a separate PR, or I could just drop it.