Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revset: prep for migrating parser and alias substition function #3768

Merged
merged 5 commits into from
May 29, 2024
Merged

revset: prep for migrating parser and alias substition function #3768

merged 5 commits into from
May 29, 2024

Conversation

yuja
Copy link
Collaborator

@yuja yuja commented May 27, 2024

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

torquestomp
torquestomp requested changes May 28, 2024
View reviewed changes
lib/src/dsl_util.rs Outdated Show resolved Hide resolved
lib/src/dsl_util.rs Show resolved Hide resolved
lib/src/dsl_util.rs Show resolved Hide resolved
@yuja yuja force-pushed the push-qrkkxmwxwzpz branch from d415cec to 4b290e1 Compare May 28, 2024 23:28
yuja added 5 commits May 29, 2024 16:08
@yuja
fileset: insert missed blank line
a32cc9e
@yuja
dsl_util: add helper function that formats arguments count error message
49d9b45
@yuja
dsl_util: forward upper-bounded expect_*_arguments() to common function
cda477d 
I'm going to add keyword arguments handling, and I want to deduplicate check
for unsupported arguments.
@yuja
dsl_util: use .ok() to drop unprintable error
d85a3b7 
I used .map_err(|_: Vec<_>|) to clarify that the original data is returned as
an error (so it can't be .unwrap()-ed.) However, it can be said that the error
detail isn't important and .map_err() is too verbose.
@yuja
dsl_util: add keyword arguments and parsing helper to FunctionCallNode
d6b8071 
This will replace revset_parser::expect_named_arguments(). More tests will be
added by migrating revset parsing.
@yuja yuja force-pushed the push-qrkkxmwxwzpz branch from 4b290e1 to d6b8071 Compare May 29, 2024 07:14
@yuja yuja merged commit b0845d1 into martinvonz:main May 29, 2024
16 checks passed
@yuja yuja deleted the push-qrkkxmwxwzpz branch May 29, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torquestomp torquestomp torquestomp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuja @torquestomp