Martin/nordea mapper #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the TransactionID config option and instead set the transaction id based on the BankID. Less config options makes for a simpler program.
Add mapper thats specific to Nordea which has some quirks that needs to be handled differently than the default mapper. I would like to get rid of the logic inside the default mapper eventually and have all the logic in bank specific mappers. The goal of this is to have less config values and less stuff the user needs to reason about. Its getting hard to remember how setting X affects each bank and what it needs to be for each bank, so lets just put it directly in code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to get rid of the logic inside the default mapper and have all the logic in bank-specific mappers. The goal of this is to have fewer config values and less stuff the user needs to reason about. It's getting hard to remember how. setting X affects each bank and what it needs to be for each bank, so let's just put it directly in the code instead.