Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nordigen)!: add requisition hook #58

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Conversation

martinohansen
Copy link
Owner

Rework the requisition fulfillment to be under the Reader struct and simplify the file handling.

Move the requisition hook to the Nordigen config struct and make it more generic so i can be used to handle arbitrary events tied to the requisition and its status.

BREAKING CHANGE: Remove NORDIGEN_DATAFILE in favor of the YNABBER_DATADIR option. This will require recreating the requisition.

@martinohansen
Copy link
Owner Author

martinohansen commented Dec 22, 2023

@CanYumusak here it is, it's bundled with a few other overdue changes. Please let me know if it still solves your issue, i made the feature more generic in the hopes of more people finding it useful.

Rework the requisition fulfillment to be under the Reader struct and
simplify the file handling.

Move the requisition hook to the Nordigen config struct and make it more
generic so i can be used to handle arbitrary events tied to the
requisition and its status.

BREAKING CHANGE: Remove NORDIGEN_DATAFILE in favor of the
YNABBER_DATADIR option. This will require recreating the requisition.
Copy link
Contributor

@CanYumusak CanYumusak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks way better, thanks

@martinohansen martinohansen merged commit 772718d into main Dec 22, 2023
3 checks passed
@martinohansen martinohansen deleted the martin/reqs-v2 branch December 22, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants