Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling with
-DCMAKE_CXX_FLAGS=-Dnsel_P2505R=
, as documented in the README to disable P2505 support, the macro expansions resulted in an empty string, leading to errors like this on all expansions:This fixes that by changing the version checks to use
(nsel_P2505R+0)
. Since R0 is not implemented, and this results in an expansion to(+0)
in the case of an emptynsel_P2505R
macro, and disabling the feature.Also adds missing
#if
blocks around theinvoke
test. related error:Alternatively, we could assign the value
-1
(or anything less than 3) to disabled in the README, which would not need the(+0)
workaround. Just write a comment if you prefer that, and I can quickly update the pull request.