Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spearbit Audit Changes #20

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Spearbit Audit Changes #20

merged 1 commit into from
Aug 22, 2024

Conversation

hexonaut
Copy link
Contributor

Changes:

  • Don't silently cast the gas limit in Optimism

@hexonaut hexonaut self-assigned this Aug 21, 2024
@hexonaut hexonaut marked this pull request as ready for review August 21, 2024 11:51
@hexonaut hexonaut marked this pull request as draft August 21, 2024 11:52
Copy link

Coverage after merging spearbit-fixes into master will be

100.00%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src/forwarders
   AMBForwarder.sol100%100%100%100%
   ArbitrumForwarder.sol100%100%100%100%
   CCTPForwarder.sol100%100%100%100%
   OptimismForwarder.sol100%100%100%100%
src/receivers
   AMBReceiver.sol100%100%100%100%
   ArbitrumReceiver.sol100%100%100%100%
   CCTPReceiver.sol100%100%100%100%
   OptimismReceiver.sol100%100%100%100%

Copy link
Contributor

@lucas-manuel lucas-manuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving pending spearbit responds indicating that its complete and don't want issue-based PRs

@@ -15,24 +15,24 @@ library OptimismForwarder {
address l1CrossDomain,
address target,
bytes memory message,
uint256 gasLimit
uint32 gasLimit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Original comment here

Copy link
Contributor

@barrutko barrutko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucas-manuel
Copy link
Contributor

Addresses the following Spearbit issues:

https://github.com/spearbit-audits/review-makerdao/issues/20

@hexonaut hexonaut merged commit 95edd63 into master Aug 22, 2024
3 checks passed
@hexonaut hexonaut deleted the spearbit-fixes branch August 22, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants