[SC-437] Fixing coverage by adding unit tests #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barrutko
requested changes
Jun 11, 2024
lucas-manuel
requested changes
Jun 11, 2024
test/CCTPReceiver.t.sol
Outdated
| function test_handleReceiveMessage_success() public { | ||
| assertEq(target.data(), 0); | ||
| vm.prank(destinationMessenger); | ||
| receiver.handleReceiveMessage( |
There was a problem hiding this comment.
May as well assert return value here
test/IntegrationBase.t.sol
Outdated
| @@ -105,6 +105,16 @@ abstract contract IntegrationBaseTest is Test { | |||
| assertEq(moSource.length(), 2); | |||
| assertEq(moSource.messages(0), 3); | |||
| assertEq(moSource.messages(1), 4); | |||
|
|
|||
| // One more message to destination | |||
There was a problem hiding this comment.
Don't we want another to source as well to make sure that both relays handle correctly?
There was a problem hiding this comment.
ya good point, added
lucas-manuel
added
Status: Revisions Needed
and removed
Status: Ready for Review
labels
lucas-manuel
requested changes
Jun 12, 2024
test/CCTPReceiver.t.sol
Outdated
Comment on lines
84
to
85
| assertEq(result, true); | ||
| assertEq(target.count(), 1); |
lucas-manuel
added
Status: Revisions Needed
and removed
Status: Ready for Review
labels
|
Coverage after merging SC-437-fix-coverage into SC-452-refactor-forwards-receivers will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
lucas-manuel
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding unit tests to the receiver contracts for more robust testing and it fixes coverage issues.
Please note I also updated the import to relative to fix an issue with having this as a library. It wouldn't resolve the types properly otherwise.
Also, fixing a bug with subsequent message relays on all testing frameworks.