Fix: broadcast create transaction #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hexonaut
approved these changes
Dec 16, 2024
krzkaczor
reviewed
Dec 16, 2024
src/periphery/forge/index.ts
Outdated
| .cwd(cwd) | ||
| .json() | ||
| core.info(`Deployed spell ${contractName} to address ${result.deployedTo}`) | ||
| core.debug(`Deploy result: ${result}`) |
There was a problem hiding this comment.
Are u sure that result doesn't leak Tenderly's admin RPC URL for example? I assume that the debug log output is public for public repos... I would probably remove this line.
Logging concrete data with core.info is fine IMO.
There was a problem hiding this comment.
I haven't checked that specifically, but also remember that the warning messages that made me realize of the newly added --broadcast flag weren't present in the json output
Also given foundry is likely to push breaking changes like the one motivating this PR, even if secrets aren't being leaked now, they could be leaked with future foundry updates.
Good catch, thanks! implemented it in e75276a
krzkaczor
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
foundry pushed a breaking change adding the
--broadcastflag toforge create, making a dry run the defaultlogging should make it more evident if something like this happens in the future, but I'm open to removing it