Allow triggering multiple times after the module has been triggered once #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barrutko
previously approved these changes
Mar 18, 2024
lucas-manuel
requested changes
Mar 18, 2024
lucas-manuel
added
Status: Revisions Needed
and removed
Status: Ready for Review
labels
|
Coverage after merging allow-multiple-triggers into master will be
Coverage Report
|
|||||||||||||||||||
barrutko
approved these changes
Mar 18, 2024
lucas-manuel
approved these changes
Mar 18, 2024
barrutko
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChainSecurity audit brought up a good point that the kill switch module might be triggered while a new asset is being onboarded. It will be better to disable borrowing on that new asset with a repeated call to
trigger()and only when governance explicitly resets the module we go back into default mode.