[SC-324] Deny can be triggered by auth #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucas-manuel
requested changes
Feb 20, 2024
lucas-manuel
added
Status: Revisions Needed
and removed
Status: Ready for Review
labels
|
Coverage after merging SC-324-remove-multisig-no-delay into master will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||
lucas-manuel
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow deny to be called by
authinstead of only the owner. This will allow both the MKR spell and the multisig itself to remove its own access. This is important in the event of abuse.It's ok to allow the multisig to remove itself as this should be grouped into the same category as abuse. IE 2+ of the signers are doing things they shouldn't be doing.