feat: Add freeze all assets spell, integration for all assets (SC-243) #3
Conversation
lucas-manuel
changed the base branch from
master
to
sc-239-add-spells-and-tests
| assertTrue(authority.hat() != address(freezeAssetSpell)); | ||
| assertTrue( |
There was a problem hiding this comment.
Instead of assertTrue and ! why not just use assertFalse?
There was a problem hiding this comment.
(in all of the cases with this pattern)
test/IntegrationTests.t.sol
Outdated
| poolConfig.setSupplyCap(asset, 68_719_476_735); // MAX_SUPPLY_CAP | ||
| poolConfig.setBorrowCap(asset, 68_719_476_735); // MAX_BORROW_CAP |
There was a problem hiding this comment.
Where these numbers exactly come from?
There was a problem hiding this comment.
There was a problem hiding this comment.
Some changes, but also just realized both spells should have a flag set so that it can only be fired once. We will deploy a new spell for each time we want to use this. Otherwise users can freeze the market over and over until the hat changes. Additional tests should be added to ensure the precrafted spells can only execute at most once.
Also, the spell unfreezing wbtc and dai ltv to 0 will execute tomorrow, so let's get those changes added before merging this as well.
lucas-manuel
added
Status: Ready for Review
and removed
Status: Revisions Needed
labels
|
Coverage after merging sc-243-add-freeze-all into master will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||
No description provided.