Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SC-466] Add testing support psm variant 2 #6

Merged
merged 10 commits into from
Jul 4, 2024
Merged

Conversation

hexonaut
Copy link
Contributor

@hexonaut hexonaut commented Jul 1, 2024

Adding testing for the new dss lite psm. This is psm is designed to be backwards compatible, but wanting to make sure in advance we don't need any code changes. I would recommend diffing the Variant1 and 2 test code as it's almost identical.

Also I've updated the README to match the latest requirements.

@hexonaut hexonaut requested review from barrutko and lucas-manuel July 1, 2024 11:41
@hexonaut hexonaut self-assigned this Jul 1, 2024
@hexonaut hexonaut changed the title Add testing support psm variant 2 [SC-466] Add testing support psm variant 2 Jul 1, 2024
test/mocks/PSMVariant2Mock.sol Show resolved Hide resolved
test/PSMVariant2Actions.t.sol Show resolved Hide resolved
test/mocks/PSMVariant2Mock.sol Outdated Show resolved Hide resolved
@hexonaut hexonaut requested a review from lucas-manuel July 4, 2024 08:28
Copy link

github-actions bot commented Jul 4, 2024

Coverage after merging psm-variant2-support into master will be

100.00%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   PSMVariant1Actions.sol100%100%100%100%

Copy link

@barrutko barrutko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reapproving after last alignment fix

@hexonaut hexonaut merged commit 5f4885e into master Jul 4, 2024
3 checks passed
@hexonaut hexonaut deleted the psm-variant2-support branch July 4, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants