Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add PSM pocket change (SC-724) #43

Merged
merged 4 commits into from
Oct 5, 2024

Conversation

lucas-manuel
Copy link
Contributor

Updates to:

  • Account for balance of USDC in pocket for totalAssets() accounting
  • Transfer assets in and out of the pocket for deposit/withdraw/swaps
  • Add an invariant test suite to set the pocket and maintain accounting
  • Add additional test coverage for different pocket scenarios
  • Add coverage to demonstrate breaking accounting (Start with PSM as default, get deposits, transfer pocket to another address, check totalAssets - this saw a drop in totalAssets before fix)
  • Update testing to use a non-psm pocket by default

Copy link

github-actions bot commented Oct 4, 2024

Coverage after merging sc-724-psm-pocket-change into master will be

100.00%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
deploy
   PSM3Deploy.sol100%100%100%100%
src
   PSM3.sol100%100%100%100%

Copy link
Contributor

@hexonaut hexonaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Very thorough.

@lucas-manuel lucas-manuel merged commit 1e14233 into master Oct 5, 2024
3 checks passed
@lucas-manuel lucas-manuel deleted the sc-724-psm-pocket-change branch October 5, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants