Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Add coverage back #19

Merged
merged 3 commits into from
Jul 5, 2024
Merged

ci: Add coverage back #19

merged 3 commits into from
Jul 5, 2024

Conversation

lucas-manuel
Copy link
Contributor

No description provided.

@lucas-manuel lucas-manuel requested review from hexonaut and barrutko July 4, 2024 10:57
@lucas-manuel lucas-manuel self-assigned this Jul 4, 2024
@lucas-manuel lucas-manuel changed the title ci: Add coverage backgp ci: Add coverage back Jul 4, 2024
hexonaut
hexonaut requested changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@hexonaut hexonaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor formatting. Not sure why the withdraw modifications are included in this PR, but the change seems fine.

test/unit/Withdraw.t.sol Outdated Show resolved Hide resolved
@lucas-manuel lucas-manuel requested a review from hexonaut July 5, 2024 11:35
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 5, 2024

Coverage after merging add-coverage-back into master will be

98.94%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   PSM3.sol97.86%98.61%90.48%98.94%237, 240

@lucas-manuel lucas-manuel merged commit d30e45d into master Jul 5, 2024
2 of 3 checks passed
@lucas-manuel lucas-manuel deleted the add-coverage-back branch July 5, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hexonaut hexonaut hexonaut approved these changes

@barrutko barrutko Awaiting requested review from barrutko

Assignees

@lucas-manuel lucas-manuel

Labels
Priority: High Status: Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucas-manuel @hexonaut