Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add ghost variables and inline assertions (SC-485) #17

Merged
merged 186 commits into from
Jul 29, 2024

Conversation

lucas-manuel
Copy link
Contributor

No description provided.

test/invariant/Invariants.t.sol Outdated Show resolved Hide resolved
test/invariant/Invariants.t.sol Outdated Show resolved Hide resolved
test/invariant/handlers/RateSetterHandler.sol Show resolved Hide resolved
test/invariant/handlers/TransferHandler.sol Show resolved Hide resolved
Copy link
Contributor

@hexonaut hexonaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine now. I've got passing on my local machine, but CI is failing.

test/invariant/Invariants.t.sol Outdated Show resolved Hide resolved
hexonaut
hexonaut previously approved these changes Jul 29, 2024
Copy link
Contributor

@hexonaut hexonaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucas-manuel lucas-manuel requested a review from hexonaut July 29, 2024 14:19
Copy link

Coverage after merging sc-485-ghost-variables-inline-assertions into master will be

100.00%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   PSM3.sol99.52%100%95.83%100%

@lucas-manuel lucas-manuel merged commit 7d1d7bc into master Jul 29, 2024
3 checks passed
@lucas-manuel lucas-manuel deleted the sc-485-ghost-variables-inline-assertions branch July 29, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants