Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Use DSROracle in invariant tests (SC-484) #16

Merged
merged 119 commits into from
Jul 4, 2024
Merged

test: Use DSROracle in invariant tests (SC-484) #16

merged 119 commits into from
Jul 4, 2024

Conversation

lucas-manuel
Copy link
Contributor

No description provided.

lucas-manuel added 30 commits May 18, 2024 11:02
@lucas-manuel
feat: first test working
822694a
@lucas-manuel
feat: use larger numbers:
d6530e1
@lucas-manuel
feat: test with initial burn amount passing
8f11df4
@lucas-manuel
feat: update tests to work with updated burn logic, move conversion f…
78fb4ad 
…unctions around and use previews
@lucas-manuel
feat: remove todos
d32fd2f
@lucas-manuel
fix: update to remove console and update comment
2290417
@lucas-manuel
feat: get swap tests working
1fe351b
@lucas-manuel
feat: get all swap tests working
cbea0ee
@lucas-manuel
fix: update for three assets in logic
7d1101d
@lucas-manuel
feat: all tests passing
80440e0
@lucas-manuel
fix: rm commented out test
51b980d
@lucas-manuel
feat: add preview swap tests
e6b67c6
@lucas-manuel
feat: move logic out of single use internal and use conversion rate e…
ffa4513 
…verywhere
@lucas-manuel
feat: move divRoundUp out of single use internal
e9c519b
@lucas-manuel
feat: add full coverage for conversion tests
6ec2b23
@lucas-manuel
feat: add more preview cases
2be5afc
@lucas-manuel
feat: refactor PSM to use three assets
4299e03
@lucas-manuel
fix: rm comment
64c9939
@lucas-manuel
feat: add interface, natspec, events, referral code, tests passing
2c43f92
@lucas-manuel
fix: update to rm consolegp
57c65d6
@lucas-manuel
Merge branch 'sc-447-build-threeway-swap' into sc-448-add-referral-code
c0616bf
@lucas-manuel
feat: add events testing
416034f
@lucas-manuel
feat: make precisions internal and add state var natspec
114f92b
@lucas-manuel
feat: finish natspec
8c2f83b
@lucas-manuel
feat: add readme
61443c8
@lucas-manuel
feat: add referral code note
6ca25a8
@lucas-manuel
fix: update constructor test
c4f8c78
@lucas-manuel
fix: update links
b070a44
@lucas-manuel
fix: reformatting
6947398
@lucas-manuel
fix: update testing section
9bdcfc5
@lucas-manuel lucas-manuel self-assigned this Jun 24, 2024
@lucas-manuel lucas-manuel changed the title feat: Use DSROracle in invariant tests (SC-484) test: Use DSROracle in invariant tests (SC-484) Jun 24, 2024
Base automatically changed from sc-483-add-rate-changes to master July 3, 2024 10:59
hexonaut
hexonaut requested changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@hexonaut hexonaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two issues, but lgtm other than that.

test/invariant/handlers/TimeBasedRateHandler.sol Outdated Show resolved Hide resolved
test/invariant/handlers/TimeBasedRateHandler.sol Outdated Show resolved Hide resolved
@lucas-manuel lucas-manuel requested a review from hexonaut July 4, 2024 10:29
@lucas-manuel lucas-manuel merged commit ebef16e into master Jul 4, 2024
2 checks passed
@lucas-manuel lucas-manuel deleted the sc-484-time-based-rates branch July 4, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hexonaut hexonaut hexonaut approved these changes

@barrutko barrutko Awaiting requested review from barrutko

Assignees

@lucas-manuel lucas-manuel

Labels
Priority: Medium Status: Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucas-manuel @hexonaut