replaced references from sparkprotocol.io to spark.fi #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tadeongmi is attempting to deploy a commit to the Mars Foundation Team on Vercel. A member of the Team first needs to authorize it. |
tomeq93
reviewed
Nov 21, 2023
| @@ -82,25 +82,25 @@ export const Disclaimers = () => { | |||
| ( | |||
| <Trans> | |||
| By using this Site, I have read and agree to the{' '} | |||
| <a href="https://www.sparkprotocol.io/terms-of-use.html" target="blank"> | |||
| <a href="https://www.spark.fi/terms-of-use.html" target="blank"> | |||
There was a problem hiding this comment.
Are those proper links? They're not working for me.
There was a problem hiding this comment.
weird, it has to do with "www"
There was a problem hiding this comment.
The urls should be updated to use the apex domain.
|
got some problem when running dev
|
yivlad
approved these changes
Nov 21, 2023
tomeq93
approved these changes
Nov 21, 2023
krzkaczor
approved these changes
Nov 21, 2023
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hexonaut
requested changes
Nov 22, 2023
There was a problem hiding this comment.
Please update to use the apex domain spark.fi instead of www.spark.fi wherever relevant.
|
@hexonaut this cannot be solved on the DNS side? |
|
It's better to use the actual link, but it also redirects on DNS level. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General Changes
manually replaced mentions of sparkprotocol.io with spark.fi
Developer Notes
there are some elements that are not used, like AMPL tooltip so I added generic link to new docs.
Author Checklist
Please ensure you, the author, have gone through this checklist to ensure there is an efficient workflow for the reviewers.
mainIf the PR is ready for review:
Openstate and not inDraftmodeReady for Dev Reviewlabel has been addedReviewer Checklist
Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.
.env.examplefile as well as the pertinant.github/actions/*files