Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FRO-137: fix sdai supply apy #167

Merged
merged 2 commits into from
Nov 10, 2023
Merged

FRO-137: fix sdai supply apy #167

merged 2 commits into from
Nov 10, 2023

Conversation

tomeq93
Copy link
Contributor

@tomeq93 tomeq93 commented Nov 8, 2023

No description provided.

Copy link

vercel bot commented Nov 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spark-interface-production-like ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2023 10:13am
spark-interface-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2023 10:13am

@tomeq93
Copy link
Contributor Author

tomeq93 commented Nov 8, 2023

as I understood we should only remove it from "Your Wallet" section and still render it as it was on "Your Deposits", correct @krzkaczor?

@tomeq93 tomeq93 requested a review from krzkaczor November 8, 2023 11:06
@krzkaczor krzkaczor requested a review from hexonaut November 8, 2023 11:15
@krzkaczor
Copy link
Contributor

@hexonaut is this correct?
image

@hexonaut
Copy link
Collaborator

hexonaut commented Nov 9, 2023

Correct it should show 0%, but also it should be removed for all instances including "Your Wallet" and "Your Deposits".

@tomeq93
Copy link
Contributor Author

tomeq93 commented Nov 9, 2023

@hexonaut 👍 should be good now, could you take a final look?

Copy link
Collaborator

@hexonaut hexonaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomeq93 tomeq93 merged commit b168683 into spark Nov 10, 2023
3 checks passed
@tomeq93 tomeq93 deleted the FRO-137/fix-sdai-supply-apy branch November 10, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants