Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove banner prompting to migrate from Aave v2 #162

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

yivlad
Copy link
Contributor

@yivlad yivlad commented Oct 19, 2023

General Changes

  • Removes banner prompting to migrate from Aave v2

Developer Notes

Add any notes here that may be helpful for reviewers.


Author Checklist

Please ensure you, the author, have gone through this checklist to ensure there is an efficient workflow for the reviewers.

  • The base branch is set to main
  • The title is using Conventional Commit formatting
  • The Github issue has been linked to the PR in the Development section
  • The General Changes section has been filled out
  • Developer Notes have been added (optional)

If the PR is ready for review:

  • The PR is in Open state and not in Draft mode
  • The Ready for Dev Review label has been added

Reviewer Checklist

Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.

  • End-to-end tests are passing without any errors
  • Code style generally follows existing patterns
  • Code changes do not significantly increase the application bundle size
  • If there are new 3rd-party packages, they do not introduce potential security threats
  • If there are new environment variables being added, they have been added to the .env.example file as well as the pertinant .github/actions/* files
  • There are no CI changes, or they have been approved by the DevOps and Engineering team(s)
  • Code changes have been quality checked in the ephemeral URL
  • QA verification has been completed
  • There are two or more approvals from the core team
  • Squash and merge has been checked

@vercel
Copy link

vercel bot commented Oct 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spark-interface-production-like ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 19, 2023 2:38pm
spark-interface-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 19, 2023 2:38pm

Copy link
Contributor

@krzkaczor krzkaczor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

showMigrateButton is still used in this file (for mobile version) please remove as well.

@yivlad
Copy link
Contributor Author

yivlad commented Oct 19, 2023

showMigrateButton is still used in this file (for mobile version) please remove as well.

Screenshot 2023-10-19 at 16 26 43

It's used for the button on the right side - should we remove it as well?

@krzkaczor
Copy link
Contributor

@yivlad i think so. It's the same thing.

@yivlad yivlad merged commit 6ffb19c into spark Oct 19, 2023
3 checks passed
@yivlad yivlad deleted the fro-74-removehide-banner-to-migrate-from-aave-v2 branch October 19, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants