Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the useless isActionQueued logic #23

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Remove the useless isActionQueued logic #23

merged 1 commit into from
Jul 31, 2024

Conversation

hexonaut
Copy link
Contributor

@hexonaut hexonaut commented Jul 30, 2024

From audit review. The logic to prevent duplicate actions is pointless unless it is queued up in the same batch. Bridges already provide guarantees that a single relayed message will only be executed at most once or it would be a very broken bridge.

Copy link

Coverage after merging audit-fixes into master will be

100.00%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   Executor.sol100%100%100%100%

@hexonaut hexonaut merged commit 5ed105f into master Jul 31, 2024
3 checks passed
@hexonaut hexonaut deleted the audit-fixes branch July 31, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants