-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
formatting: First round of cleanup #21
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucas-manuel
changed the title
feat: Update with new cleanup
formatting: Update with new cleanup
Jun 13, 2024
lucas-manuel
changed the title
formatting: Update with new cleanup
formatting: First round of cleanup
Jun 13, 2024
Base automatically changed from
SC-472-guardian-merge-into-access-control
to
SC-463-merge-auth-bridge
June 14, 2024 07:06
Coverage after merging first-cleanup into master will be
Coverage Report
|
hexonaut
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. executeDelegateCall
is needed to supply an ETH msg.value
for a delegate call.
barrutko
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
_actionsSetCounter
toactionsSetCount
so it makes more sense as a public function_queuedActions
toisActionQueued
and get rid of redundantisActionQueued
view functionOpen Questions
What should we say instead of
misc functions
? Do we needexecuteDelegateCall
anymore?