[SC-430] Revert on non-existent contract instead of silent success #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… add some more testing coverage for revert cases
barrutko
previously approved these changes
Jun 10, 2024
lucas-manuel
requested changes
Jun 10, 2024
lucas-manuel
added
Status: Revisions Needed
and removed
Status: Ready for Review
labels
|
Coverage after merging SC-430-error-on-empty-contract into master will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||
barrutko
approved these changes
Jun 11, 2024
lucas-manuel
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched to using the OZ
Addresshelper library which does an additional check for empty addresses and reverts if so. This will help with things like cross-chain payload e2e testing to have them fail when the address is not deployed. Also added some more testing coverage for these types of failure cases with delegatecall and call.