Add constant padding to random hexes, hashes and addresses #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…ve-a-common-prefix
📦 Size Report
|
krzkaczor
reviewed
Dec 16, 2024
| @@ -19,10 +19,11 @@ export function CheckedAddress(value: string): CheckedAddress { | |||
| * Generates a random address. Tries to represent desired ascii prefix as hex value. Helps to identify transactions in the logs. | |||
| */ | |||
| CheckedAddress.random = (asciiPrefix = ''): CheckedAddress => { | |||
| const constantAddressPrefix = '0000' | |||
There was a problem hiding this comment.
i thought about this more: i think a good prefix is deadbeef as it's obviously not random. Or simply make the prefix longer - for example: 8 chars instead of 4.
There was a problem hiding this comment.
changed to deadbeef
oskarvu
reviewed
Dec 17, 2024
| @@ -19,10 +19,11 @@ export function CheckedAddress(value: string): CheckedAddress { | |||
| * Generates a random address. Tries to represent desired ascii prefix as hex value. Helps to identify transactions in the logs. | |||
| */ | |||
| CheckedAddress.random = (asciiPrefix = ''): CheckedAddress => { | |||
There was a problem hiding this comment.
I guess it will be infix now, since it's not first part of the address anymore.
I'm curious, why this change was needed in the first place?
There was a problem hiding this comment.
I don't know if we need to be that precise to rename that to infix - both of these parts are still prerandomPart 😛
…ve-a-common-prefix
yivlad
approved these changes
Dec 17, 2024
oskarvu
approved these changes
Dec 17, 2024
…ve-a-common-prefix
barrutko
deleted the
sc-885-random-hashes-and-addresses-should-have-a-common-prefix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.