Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll to actions after hitting borrow button #493

Merged
merged 3 commits into from
Dec 17, 2024

Conversation

oskarvu
Copy link
Contributor

@oskarvu oskarvu commented Dec 16, 2024

Closes FRO-1158

Copy link

vercel bot commented Dec 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 5:56am
spark-app-production ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 5:56am
spark-app-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 5:56am

Copy link

github-actions bot commented Dec 16, 2024

📦 Size Report

Path Size Diff
JS 1.3 MB -14 B (-0.01% 🔽)
CSS 23.28 KB 0 B (0%)

@@ -199,7 +199,7 @@ export function useEasyBorrow(): UseEasyBorrowResults {
)
useEffect(() => {
if (pageStatus === 'confirmation') {
healthFactorPanelRef.current?.scrollIntoView({ behavior: 'smooth', block: 'start' })
actionsPanelRef.current?.scrollIntoView({ behavior: 'smooth', block: 'start' })
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can also be done using ref callbacks on actions panel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants