Add common-testnets package #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Oskar <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📦 Size Report
|
yivlad
force-pushed
the
yivlad/add-common-testnets-package
branch
from
ad0bebf to
a57ae32
Compare
krzkaczor
reviewed
Dec 12, 2024
|
|
||
| assert(result === true, 'revert failed') | ||
|
|
||
| // anvil snapshot are "burned" after revert so we need to create a new one |
There was a problem hiding this comment.
Suggested change
| // anvil snapshot are "burned" after revert so we need to create a new one | |
| // anvil snapshots are "burned" after revert so we need to create a new one |
.github/workflows/ci.yml
Outdated
| @@ -65,7 +65,8 @@ jobs: | |||
| - run: pnpm install | |||
|
|
|||
| - run: pnpm check | |||
| - run: pnpm verify # does linting, type checking, and tests in parallel | |||
| - name: Verify # verifies all packages except common-testnets | |||
| run: pnpm run --parallel --aggregate-output --reporter append-only --filter './packages/{app,common-nodejs,common-universal}' verify | |||
There was a problem hiding this comment.
i think we can simplify this. So the mental model should be that verify is fast (linting, unit tests etc) and we can always run in on every single project. In case of common-testnets verify would run eslint and typecheck but no tests because these are not unit tests but rather integration/e2e tests. So the task should be renamed to test-e2e and then the CI job for testnets runs only that.
krzkaczor
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.