Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

common-nodejs package #480

Merged
merged 28 commits into from
Dec 11, 2024
Merged

common-nodejs package #480

merged 28 commits into from
Dec 11, 2024

Conversation

krzkaczor
Copy link
Contributor

@krzkaczor krzkaczor commented Dec 9, 2024 •
edited
Loading

  • added common-nodejs package with nodejs utils such as logger, env parsing etc.
  • also added missing assertNever and PrivateKey type to common-universal
  • normalizing the app codebase to use assertNever from common-universal will be done in a separate PR

@vercel Vercel
Copy link

vercel bot commented Dec 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 9:19pm
spark-app-production ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 9:19pm
spark-app-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 9:19pm

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024 •
edited
Loading

📦 Size Report

Path Size Diff
JS 1.25 MB -1.92 KB (-0.15% 🔽)
CSS 23.2 KB 0 B (0%)

@krzkaczor krzkaczor marked this pull request as draft December 9, 2024 09:34
@krzkaczor krzkaczor requested review from oskarvu and yivlad December 10, 2024 21:09
@krzkaczor krzkaczor marked this pull request as ready for review December 10, 2024 21:09
@krzkaczor krzkaczor merged commit 058ec62 into main Dec 11, 2024
10 checks passed
@krzkaczor krzkaczor deleted the common-packages branch December 11, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oskarvu oskarvu oskarvu approved these changes

@yivlad yivlad Awaiting requested review from yivlad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krzkaczor @oskarvu