Mixpanel post merge changes (#486)

* Change order mixpanel analytics variables * Add comment about usefulness of delaying showing cookie banner
marsfoundation · Dec 11, 2024 · 201bf42 · 201bf42
1 parent ddc974d
commit 201bf42
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/packages/app/src/domain/analytics/mixpanel.ts b/packages/app/src/domain/analytics/mixpanel.ts
@@ -22,13 +22,6 @@ export interface Analytics {
   trackEvent(event: string, props?: Record<string, any>): void
 }
 
-const analyticsDisabled: Analytics = {
-  optInTracking: () => {},
-  optOutTracking: () => {},
-  trackUserAddress: (_address: CheckedAddress) => {},
-  trackEvent: (_event: string, _props: Record<string, any> = {}) => {},
-}
-
 const analyticsEnabled: Analytics = {
   optInTracking: () => {
     if (!mixpanel.has_opted_in_tracking()) {
@@ -48,6 +41,13 @@ const analyticsEnabled: Analytics = {
   },
 }
 
+const analyticsDisabled: Analytics = {
+  optInTracking: () => {},
+  optOutTracking: () => {},
+  trackUserAddress: (_address: CheckedAddress) => {},
+  trackEvent: (_event: string, _props: Record<string, any> = {}) => {},
+}
+
 export const { optInTracking, optOutTracking, trackUserAddress, trackEvent } = MIXPANEL_ENABLED
   ? analyticsEnabled
   : analyticsDisabled
diff --git a/packages/app/src/features/analytics/logic/useAnalytics.ts b/packages/app/src/features/analytics/logic/useAnalytics.ts
@@ -19,6 +19,8 @@ export function useAnalytics(): UseAnalyticsResult {
     optOutTracking()
   }
 
+  // @note: We are delaying showing the banner until the initial data is loaded and skeleton is removed.
+  // This is because we need to drag user's attention to the banner and we don't want to show it too early.
   const initialDataLoaded = useInitialDataLoaded()
 
   return {