Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure DATA_PATH is always a pathlib.Path #549

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Make sure DATA_PATH is always a pathlib.Path #549

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions vermouth/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@
import atexit
from contextlib import ExitStack
except ImportError:
import os
DATA_PATH = os.path.join(os.path.dirname(__file__), 'data')
del os
from pathlib import Path
DATA_PATH = Path(__file__).parent / 'data'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pathlib works os independent right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's kind of the whole point. os.path does as well, but that API is less nice since you need to do os.path.join all the time rather than inlining a /

del Path
else:
ref = files('vermouth') / 'data'
file_manager = ExitStack()
Expand Down