Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated pkg_resources with new importlib #546

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Replace deprecated pkg_resources with new importlib #546

merged 1 commit into from
Oct 4, 2023

Conversation

pckroon
Copy link
Member

@pckroon pckroon commented Oct 2, 2023

So, pkg_resources is deprecated (https://setuptools.pypa.io/en/latest/pkg_resources.html), so here I change it for importlib as recommended.

See also https://importlib-resources.readthedocs.io/en/latest/migration.html

@pckroon pckroon added the hacktoberfest-accepted Accepted Hacktoberfest contribution label Oct 2, 2023
@pckroon pckroon requested a review from fgrunewald October 2, 2023 09:47
fgrunewald
fgrunewald approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@fgrunewald fgrunewald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Slightly annoying that the one line is replaced by these couple of lines and managers though.

@pckroon pckroon merged commit 914b4fa into master Oct 4, 2023
@pckroon pckroon deleted the importlib branch October 4, 2023 13:32
@fgrunewald fgrunewald mentioned this pull request Oct 5, 2023
Merged
@pckroon pckroon restored the importlib branch October 5, 2023 12:46
@pckroon pckroon mentioned this pull request Oct 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgrunewald fgrunewald fgrunewald approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Accepted Hacktoberfest contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pckroon @fgrunewald