Skip to content

Commit

Permalink
Merge branch 'testing-305-recipe-search-integration-testing-library' …
Browse files Browse the repository at this point in the history
…into testing-306-recipe-search-shallow-starter
  • Loading branch information
yjaaidi committed Nov 3, 2023
2 parents c6bc25f + ef9f0b6 commit 508c6ac
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
4 changes: 2 additions & 2 deletions apps/whiskmate/src/app/recipe/recipe-preview.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { ChangeDetectionStrategy, Component, Input } from '@angular/core';
standalone: true,
selector: 'wm-recipe-preview',
imports: [CardComponent, NgIf],
template: `<wm-card *ngIf="recipe" [pictureUri]="recipe.pictureUri">
template: `<wm-card [pictureUri]="recipe.pictureUri">
<h2 data-role="recipe-name">{{ recipe.name }}</h2>
<ng-content/>
</wm-card>`,
Expand All @@ -25,5 +25,5 @@ import { ChangeDetectionStrategy, Component, Input } from '@angular/core';
],
})
export class RecipePreviewComponent {
@Input() recipe?: Recipe;
@Input({ required: true }) recipe!: Recipe;
}
2 changes: 1 addition & 1 deletion docs/304-recipe-search-async-pipe.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ pnpm test --watch
2. Checkout new `RecipeSearchComponent` implementation.

```sh
git checkout origin/testing-308-recipe-search-async-pipe apps/whiskmate/src/app/recipe/recipe-search.component.ts
git checkout origin/testing-309-recipe-search-async-pipe apps/whiskmate/src/app/recipe/recipe-search.component.ts
```

> This will replace the imperative approach:
Expand Down
4 changes: 3 additions & 1 deletion tools/sync-testing.sh
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@ ${TOOLS_PATH}/cascade-changes.sh \
testing-305-recipe-search-integration-testing-library \
testing-306-recipe-search-shallow-starter \
testing-307-recipe-search-shallow \
testing-308-recipe-search-async-pipe \
testing-308-recipe-search-shallow-testing-library \
testing-309-recipe-search-async-pipe \
testing-310-recipe-search-signals \
testing-400-recipe-filter-starter \
testing-401-recipe-filter \
testing-402-recipe-search-filter-interaction \
Expand Down

0 comments on commit 508c6ac

Please sign in to comment.