Feat(crm): Harmonize Sales Form and My Page Form with the others #10091
+116
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnault-dev
reviewed
Jul 26, 2024
| <Container maxWidth="sm" sx={{ mt: 4 }}> | ||
| <Create redirect="list"> | ||
| <SimpleForm> | ||
| <Typography variant="h6">Create sale guy</Typography> |
There was a problem hiding this comment.
thought: I'm not a big fan of sale guy as it is quite informal and gender oriented. Mayby sale person ?
examples/crm/src/sales/SalesList.tsx
Outdated
| @@ -15,7 +15,7 @@ function SalesListActions() { | |||
| return ( | |||
| <TopToolbar> | |||
| <ExportButton /> | |||
| <CreateButton variant="contained" label="New Sale" /> | |||
| <CreateButton variant="contained" label="New sales guy" /> | |||
There was a problem hiding this comment.
Same as previous comment
arnault-dev
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution
Feat(crm): Harmonize Sales Form and My Page Form with the others