Refactor interceptors as middlewares #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
djhi
commented
Jun 4, 2024
•
djhi
commented
- Refactor interceptors as middlewares
- Add a Sinon compatible dataProvider in the example
- Update migration guide
- Documentation
|
I won't upgrade the README in this PR as I intend to rewrite it in a dedicated one |
This was referenced Jun 6, 2024
Closed
fzaninotto
requested changes
Jun 6, 2024
fzaninotto
reviewed
Jun 6, 2024
fzaninotto
reviewed
Jun 6, 2024
fzaninotto
reviewed
Jun 6, 2024
fzaninotto
reviewed
Jun 6, 2024
djhi
commented
Jun 6, 2024
Comment on lines
+31
to
+41
| throw new Response( | ||
| JSON.stringify({ | ||
| errors: { | ||
| title: 'An article with this title already exists. The title must be unique.', | ||
| }, | ||
| }), | ||
| { | ||
| status: 400, | ||
| statusText: 'Title is required', | ||
| }, | ||
| ); |
There was a problem hiding this comment.
I still use a throw Response here instead of returning an object to test that this still works
djhi
commented
Jun 6, 2024
Comment on lines
+36
to
+46
| throw new Response( | ||
| JSON.stringify({ | ||
| errors: { | ||
| title: 'An article with this title already exists. The title must be unique.', | ||
| }, | ||
| }), | ||
| { | ||
| status: 400, | ||
| statusText: 'Title is required', | ||
| }, | ||
| ); |
There was a problem hiding this comment.
I still use a throw Response here instead of returning an object to test that this still works
fzaninotto
reviewed
Jun 6, 2024
fzaninotto
reviewed
Jun 6, 2024
This was referenced Jun 6, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.