fix: empty object all results

markwylde · Dec 24, 2024 · 11dbd77 · 11dbd77
1 parent a55834d
commit 11dbd77
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 4 deletions.
diff --git a/src/index.ts b/src/index.ts
@@ -28,7 +28,7 @@ export type DoubleDb = {
   patch: (id: string, newDocument: Partial<Document>) => Promise<Document>;
   remove: (id: string) => Promise<void>;
   read: (id: string) => Promise<Document | undefined>;
-  query: (queryObject: object) => Promise<Document[]>;
+  query: (queryObject?: object) => Promise<Document[]>;
   close: () => Promise<void>;
   batchInsert: (documents: Document[]) => Promise<Document[]>;
   upsert: (id: string, document: Document) => Promise<Document>;
@@ -327,9 +327,11 @@ async function createDoubleDb(dataDirectory: string): Promise<DoubleDb> {
     return db.del(id);
   }
 
-  async function query(queryObject: object): Promise<Document[]> {
-    if (!isObject(queryObject)) {
-      throw new Error('doubledb.query: queryObject must be an object');
+  async function query(queryObject?: object): Promise<Document[]> {
+    if (!queryObject || Object.keys(queryObject).length === 0) {
+      const allIds = await getAllIds();
+      const results = await Promise.all([...allIds].map(id => read(id)));
+      return results.filter((doc): doc is Document => doc !== undefined);
     }
 
     let resultIds = new Set<string>();

diff --git a/test/query.ts b/test/query.ts
@@ -15,6 +15,17 @@ async function setupTestDb() {
   return db;
 }
 
+test('empty query', async () => {
+  const db = await setupTestDb();
+  await db.insert({ value: 'alpha' });
+  await db.insert({ value: 'beta' });
+  const result = await db.query({});
+  assert.strictEqual(result.length, 2);
+  assert.strictEqual(result[0].value, 'alpha');
+  assert.strictEqual(result[1].value, 'beta');
+  await db.close();
+});
+
 test('$sw operator on string', async () => {
   const db = await setupTestDb();
   await db.insert({ value: 'alpha' });