Run full test diff for the latest CI Python version only #65
Conversation
This reverts commit f37b514.
mvorisek
force-pushed
the
fix_ci_cron
branch
2 times, most recently
from
41f69c0 to
7bf97cb
Compare
mvorisek
force-pushed
the
fix_ci_cron
branch
4 times, most recently
from
c5d5816 to
a74f5cd
Compare
|
@markstory can this CI fix PR be merged? |
It isn't free though. It consumes resources (energy and time) and needlessly wastes those resources. |
.github/workflows/ci.yml
Outdated
| schedule: | ||
| - cron: '0 0/2 * * *' |
There was a problem hiding this comment.
| schedule: | |
| - cron: '0 0/2 * * *' |
There is no reason to heat the earth for this.
There was a problem hiding this comment.
I changed the cron to run on once per day only. The CI runtime is about a minute, so the total energy consumption is minimal.
There was a problem hiding this comment.
I refuse to merge any configuration that contains a cron schedule.
There was a problem hiding this comment.
Commited. May I still know if the reason is solely the earth heating?
|
@markstory PR feedback is addressed, is there anything else to do? |
|
Hi @markstory, this PR is here for a while and all the feedback should be addressed, may I ask you to merge it? |
|
@markstory, can you please review? |
|
@markstory wdyt? |
@markstory thank you for merging #60
fixes #60 (comment)
latestPython version should be always fully testedas older Sphinx deps might imply different than expected output, older Python versions are tested like before #60, ie. for build to pass only
I have also reenabled cron, cron is good to monitor the tests on continuous basis and thanks to GH it is visible for everyone, even for non-contributors, and is free.