-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Network schema io #44
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update network-schema-io with latest development branch,
Reading in the TN Spike file with new function. Added NeMo_TN.py file to build system - is a CLI application that will load TN JSON files and run NeMo with them.
saves the paresed spikes as csv
Was running into issues with memory limits and processing time, now uses threading, and basic JIT Includes some testing and sobel TN files for testing
Still need to write package for TN input and run.
Fixed the IO for spikes - reading files. Currently files are hardcoded as nemo_model.csv and nemo_spikes.csv. CSV does not look like it it loading in to neurons exactly right - need to double check that.
Fixed the IO for spikes - reading files. Currently files are hardcoded as nemo_model.csv and nemo_spikes.csv. CSV does not look like it it loading in to neurons exactly right - need to double check that.
Also re-wrote some of the output for nemo
Network schema io neil
Need to write Neuron init code as well as main function code and one cleanup function in read_model.c Also forked and added the Lua cmake project as a submodule. Submodule init/update is now required.
Added more descriptive file read error prompts.
Reviewed 15 of 52 files at r1, 54 of 214 files at r3, 37 of 152 files at r5, 16 of 16 files at r6, 2 of 2 files at r7. Comments from Reviewable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge pushes the first potentially working IO subsystem into the development branch.
Current known issues include #43, and a very complex build process.
Further debugging/QA needs to be done before this is ready for release. Pulling due to new work with visualization.
This change is