Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: OOP Pricing #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

marissahuysentruyt
Copy link
Owner

@marissahuysentruyt marissahuysentruyt commented Mar 1, 2023

Description

Refactor app.js to incorporate the page view/pricing object as seen in the README.
-New pagesAndPrices object to store pageview count and pricing details

To Validate

  1. Pull down all related branches
  2. Run npm install to get all dependencies
  3. Run npm run start to run project at http://localhost:8080/
  4. Verify that moving the slider displays both the pricing and pageviews according to the pagesAndPrices object (details also found in the README). When the discount toggle is on, the price should get discounted, but the pageviews remain the same.

@netlify
Copy link

netlify bot commented Mar 1, 2023

Deploy Preview for verdant-kringle-c7203c ready!

Name Link
🔨 Latest commit 6e1680b
🔍 Latest deploy log https://app.netlify.com/sites/verdant-kringle-c7203c/deploys/63ffc7fb1b71c30008d09cc2
😎 Deploy Preview https://deploy-preview-4--verdant-kringle-c7203c.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

By creating a pagesAndPrices object, the range input now displays the
price and corresponding pageviewCount. This is instead of a previous
function that determined the number of pages per dollar.
@marissahuysentruyt marissahuysentruyt marked this pull request as ready for review March 1, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant