Improve Contributing #3189
Merged
Improve Contributing #3189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've re-written some of the contributor file to try and cover some of the changes to our process.
denar90
reviewed
Sep 17, 2016
| Please remember that Marionette is a community-maintained project and, as such, | ||
| many of us are working on this in our spare time. If we haven't commented on | ||
| your pull request, please be patient. We may be available on our Gitter channel | ||
| to discuss further. |
| 3. [Running Tests](#running-tests) | ||
| 4. [Updating docs](#updating-docs) | ||
| 3. [Submitting patches and fixes](#submitting-patches-and-fixes) | ||
| 4. [Running Tests](#running-tests) | ||
|
|
There was a problem hiding this comment.
Some titles are missed:
When you don't have a bug fixDetermining your branchSubmitting a Great PatchSolving IssuesCoding GuidelinesHow we Approve Pull Requests
Maybe the were not added in purpose.
There was a problem hiding this comment.
I wanted to stick to the top-level headers here so the reader could quickly find the thing they're currently working on e.g. they're submitting a pull request.
That said, I can definitely see the arguments for including them as someone might be thinking "what do I do for docs!"
rafde
approved these changes
Sep 17, 2016
denar90
approved these changes
Sep 17, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Link to the issue: #3185