Merge pull request #31 from mariochavez/fix/update-collection-query-m…

…ethod Chroma's API might have changed at somepoint that made this method to pass empty Hashes an invalid request.
mariochavez · Dec 11, 2024 · 727a8f8 · 727a8f8
2 parents 0182576 + fc95a1a
commit 727a8f8
Show file tree

Hide file tree

Showing 3 changed files with 125 additions and 103 deletions.
diff --git a/lib/chroma/resources/collection.rb b/lib/chroma/resources/collection.rb
@@ -34,7 +34,7 @@ def initialize(id:, name:, metadata: nil)
       #   embeddings = collection.query(query_embeddings: [[1.5, 2.9, 3.3]], results: 5)
       #
       # Return an Array of Embedding with query results.
-      def query(query_embeddings:, results: 10, where: {}, where_document: {}, include: %w[metadatas documents distances])
+      def query(query_embeddings:, results: 10, where: nil, where_document: nil, include: %w[metadatas documents distances])
         payload = {
           query_embeddings:,
           n_results: results,
@@ -43,6 +43,8 @@ def query(query_embeddings:, results: 10, where: {}, where_document: {}, include
           include:
         }
 
+        payload.delete_if { |_key, value| value.nil? }
+
         result = self.class.execute_request(:post, "#{Chroma.api_url}/collections/#{id}/query", payload)
 
         if result.success?

diff --git a/notebook/.ipynb_checkpoints/Chroma Gem-checkpoint.ipynb b/notebook/.ipynb_checkpoints/Chroma Gem-checkpoint.ipynb
diff --git a/notebook/Chroma Gem.ipynb b/notebook/Chroma Gem.ipynb