Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pylint from 2.12.1 to 3.1.0 #10

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

RytoEX
Copy link

@RytoEX RytoEX commented Mar 27, 2024

When trying to add Python 3.11 and 3.12, tests failed due to a dependency chain issue with the chain starting at pylint and ending at an outdated version of wrapt that did not support Python 3.11+. The earliest version of pylint with an updated version of wrapt is pylint 2.15. However, pylint 3.1.0 is the current version, so use that instead.

This PR requires #9 because pylint 3 only supports Python 3.8+, but otherwise pylint 3.1.0 installed and the tests ran fine on my fork.

@RytoEX RytoEX marked this pull request as draft March 27, 2024 00:12
@RytoEX
Copy link
Author

RytoEX commented Mar 27, 2024

Just a note that the successful test runs are because the action pulls the latest master branch from this repo. Converting this to a Draft to prevent early merging until #9 has been merged.

@RytoEX RytoEX force-pushed the update-requirements branch from 13f13db to 420be95 Compare March 27, 2024 00:17
@marian-code
Copy link
Owner

Merged #9 we can move this ahead whenever you have the time. Thanky ou for all the other PRs :)

When trying to add Python 3.11 and 3.12, tests failed due to a
dependency chain issue with the chain starting at pylint and ending at
an outdated version of wrapt that did not support Python 3.11+. The
earliest version of pylint with an updated version of wrapt is pylint
2.15. However, pylint 3.1.0 is the current version, so use that instead.
@RytoEX RytoEX force-pushed the update-requirements branch from 420be95 to e8f6717 Compare March 27, 2024 17:20
@RytoEX RytoEX marked this pull request as ready for review March 27, 2024 17:23
@RytoEX
Copy link
Author

RytoEX commented Mar 27, 2024

Rebased and ready for review.

@RytoEX RytoEX mentioned this pull request Mar 27, 2024
@RytoEX
Copy link
Author

RytoEX commented Mar 29, 2024

@marian-code Ready at your convenience. Let me know if you need anything on this.

@marian-code marian-code merged commit b28fd04 into marian-code:master Apr 3, 2024
9 checks passed
@marian-code
Copy link
Owner

Merged, sorry for the longer waiting time.

@RytoEX RytoEX deleted the update-requirements branch April 3, 2024 19:11
@RytoEX
Copy link
Author

RytoEX commented Apr 3, 2024

No problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants