Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for spanish special chars #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

infinito84
Copy link

Hi,

I was testing Handlebars PHP with this template:

handlebars0

But, the template wasn't working with spanish accents: (chars like í ñ) and the Template was showing a blank text.

handlebars1

So, the present solution adds support applying the utf8_encode and saving the text of blank issue:

handlebars2

Regards,

@bobthecow
Copy link

That function does not do what you think it does.

@infinito84
Copy link
Author

Sorry, what does it do?

@bobthecow
Copy link

It converts from one specific encoding into utf-8. So while it might work for your data source, it will break things for anyone who isn't using that encoding.

@bobthecow
Copy link

For example, if someone already has utf-8 strings, it does this:

screen shot 2015-06-06 at 9 45 55 pm

@infinito84
Copy link
Author

Yes, you right, I think to know how to solvet it.

@infinito84
Copy link
Author

I tried with ENT_IGNORED but disappears the chars, and tried to with ENT_SUBSTITUTE but converts my chars in weird chars, i searched in Google and the answers that i found, didn't seem me much. Do you have some idea for improving this solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants