Skip to content

Commit

Permalink
Bug 1930534 [wpt PR 49108] - Run ShadowRealm tests in multiple scopes…
Browse files Browse the repository at this point in the history
…, a=testonly

Automatic update from web-platform-tests
Change 'shadowrealm' global into a shorthand for all possible ShadowRealm scopes

In order to automatically run tests not only in a ShadowRealm created in a
window scope, but also in ShadowRealms created in other realms, change the
'shadowrealm' global type to a collection, and rename the existing
ShadowRealm handler to 'shadowrealm-in-window'.

--
Remove monkeypatch of globalThis.self in ShadowRealm

As per whatwg/html#9893, ShadowRealmGlobalScope
should have a `self` attribute already. There is no need to monkeypatch it
for the test harness.

--
Factor out JS code that will be common to multiple ShadowRealm handlers

We will add multiple ShadowRealm handlers, and they will all need to set
up certain global properties. Avoid repeating this code in each handler
as well as in idlharness-shadowrealm.js.

This should also increase readability, which is good since the ShadowRealm
setup code can be confusing.

--
Add 'shadowrealm-in-shadowrealm' global

This will add to any test with global=shadowrealm in its metadata, an
.any.shadowrealm-in-shadowrealm.html variant.

The test wrapper creates an outer ShadowRealm, which creates an inner
ShadowRealm and runs the tests inside that, relaying the results through
the outer ShadowRealm.

--
Add 'shadowrealm-in-dedicatedworker' global

This will add to any test with global=shadowrealm in its metadata, an
.any.shadowrealm-in-dedicatedworker.html variant.

The test loads an intermediate .any.worker-shadowrealm.js wrapper into a
Worker, and forwards the message port to the Worker's message port so that
fetch_tests_from_worker can receive the results.

--
Add 'shadowrealm-in-sharedworker' global

This will add to any test with global=shadowrealm in its metadata, an
.any.shadowrealm-in-sharedworker.html variant.

The test loads the same intermediate .any.worker-shadowrealm.js wrapper as
.any.shadowrealm-in-dedicatedworker.html, but populates a 'port' variable
with the port received from the connect event, instead of calling the
global postMessage since that won't work in a SharedWorker.

--
Add 'shadowrealm-in-serviceworker' global

This will add to any test with global=shadowrealm in its metadata, an
.any.shadowrealm-in-serviceworker.html variant.

We have to use a slightly different .any.serviceworker-shadowrealm.js
wrapper from the wrapper used for the other types of workers, because
dynamic import() is forbidden in ServiceWorker scopes. Instead, add a
utility function to set up a fakeDynamicImport() function inside the
ShadowRealm which uses the fetch adaptor to get the module's source text
and evaluate it in the shadowRealm.

Also add a case for ServiceWorkers to getPostMessageFunc(), which returns
a postMessage() drop-in replacement that broadcasts the message to all
clients, since test result messages from the ShadowRealm are not in
response to any particular message received by the ServiceWorker.

Note '.https.' needs to be added to the test path.

--
Add 'shadowrealm-in-audioworklet' global

This will add to any test with global=shadowrealm in its metadata, an
.any.shadowrealm-in-audioworklet.html variant.

The wrapper here is similar to the one for ServiceWorkers, since dynamic
import() is also forbidden in worklet scopes. But additionally fetch() is
not exposed, so we add a utility function to set up the ability to call
the window realm's fetch() through the AudioWorklet's message port.

We also add /resources/testharness-shadowrealm-audioworkletprocessor.js to
contain most of the AudioWorklet setup boilerplate, so that it isn't
written inline in serve.py.

Note '.https.' needs to be added to the test path.

--

wpt-commits: 9c8db8af89efbe0f67b215af2a6b49e9564e2971, 65a205aea5d02ff5bea7b1a0579287035d02d6c4, eb9c8e7259ef8bd5cca5019c1ca15ccd430e81dc, 3a20c56893472783b5e20c0d61cbb7b7b278cc6d, 7d8458ed291b139307430a102180c9a617d7876e, 42160ae827c863ac6787c8451fe377901c8f0652, 59367bb21d053abb9ed6de3cca5409486816acc9, 60d6c48e5fa76876bc3924b9d6185dfb56c9ab1c
wpt-pr: 49108

UltraBlame original commit: 0a625225a525e60a048bbd6f3a94e2605c7e375b
  • Loading branch information
marco-c committed Nov 26, 2024
1 parent a41ecd6 commit bcdf213
Show file tree
Hide file tree
Showing 19 changed files with 4,191 additions and 554 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,22 @@ script
/
resources
/
testharness
-
shadowrealm
-
outer
.
js
/
/
META
:
script
=
/
resources
/
idlharness
-
shadowrealm
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,22 @@ script
/
resources
/
testharness
-
shadowrealm
-
outer
.
js
/
/
META
:
script
=
/
resources
/
idlharness
-
shadowrealm
Expand Down
287 changes: 281 additions & 6 deletions testing/web-platform/tests/docs/writing-tests/testharness.md
Original file line number Diff line number Diff line change
Expand Up @@ -1544,6 +1544,10 @@ worker
scopes
*
shadowrealm
-
in
-
window
:
runs
the
Expand Down Expand Up @@ -1596,30 +1600,294 @@ var
any
.
shadowrealm
-
in
-
window
.
html
<
/
code
>
*
shadowrealm
-
in
-
shadowrealm
:
runs
the
test
code
in
a
ShadowRealm
context
hosted
in
another
ShadowRealm
context
;
to
be
run
at
<
code
>
<
var
>
x
<
/
var
>
.
any
.
shadowrealm
-
in
-
shadowrealm
.
html
<
/
code
>
*
shadowrealm
-
in
-
dedicatedworker
:
runs
the
test
code
in
a
ShadowRealm
context
hosted
in
a
dedicated
worker
;
to
be
run
at
<
code
>
<
var
>
x
<
/
var
>
.
any
.
shadowrealm
-
in
-
dedicatedworker
.
html
<
/
code
>
*
shadowrealm
-
in
-
sharedworker
:
runs
the
test
code
in
a
ShadowRealm
context
hosted
in
a
shared
worker
;
to
be
run
at
<
code
>
<
var
>
x
<
/
var
>
.
any
.
shadowrealm
-
in
-
sharedworker
.
html
<
/
code
>
*
shadowrealm
-
in
-
serviceworker
:
runs
the
test
code
in
a
ShadowRealm
context
hosted
in
a
service
worker
;
to
be
run
at
<
code
>
<
var
>
x
<
/
var
>
.
https
.
any
.
shadowrealm
-
in
-
serviceworker
.
html
<
/
code
>
*
shadowrealm
-
in
-
audioworklet
:
runs
the
test
code
in
a
ShadowRealm
context
hosted
in
an
AudioWorklet
processor
;
to
be
run
at
<
code
>
<
var
>
x
<
/
var
>
.
https
.
any
.
shadowrealm
-
in
-
audioworklet
.
html
<
/
code
>
*
shadowrealm
:
shorthand
for
all
of
the
ShadowRealm
scopes
To
check
if
what
scope
your
test
is
run
from
a
window
or
worker
you
can
use
the
following
two
methods
that
will
Expand All @@ -1644,6 +1912,13 @@ GLOBAL
isWorker
(
)
self
.
GLOBAL
.
isShadowRealm
(
)
Although
[
the
Expand Down
16 changes: 16 additions & 0 deletions testing/web-platform/tests/dom/idlharness-shadowrealm.window.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,22 @@ script
/
resources
/
testharness
-
shadowrealm
-
outer
.
js
/
/
META
:
script
=
/
resources
/
idlharness
-
shadowrealm
Expand Down
Loading

0 comments on commit bcdf213

Please sign in to comment.