Review fix for words without example sentence

marcelorodrigo · Sep 2, 2024 · 4c7c820 · 4c7c820
1 parent e44e64d
commit 4c7c820
Show file tree

Hide file tree

Showing 4 changed files with 34 additions and 4 deletions.
diff --git a/app/Services/VocabularyService.php b/app/Services/VocabularyService.php
@@ -255,7 +255,7 @@ public function getExampleSentence($userId, $targetType, $targetId) {
             ->first();
 
         if (!$exampleSentence) {
-            throw new \Exception('Example sentence does not exist, or it belongs to a different user.');
+            return null;
         }
 
         $textBlock = new TextBlockService();

diff --git a/resources/js/components/Home/Home.vue b/resources/js/components/Home/Home.vue
@@ -83,7 +83,7 @@
                 <v-card outlined class="rounded-lg pt-0 mr-4 mb-4" width="290px">
                     <v-card-title>Version</v-card-title>
                     <v-card-text>
-                        The current LinguaCafe version is v0.13.
+                        The current LinguaCafe version is v0.13.3
                         <div class="footer-link-box mb-1 mt-4">
                             <router-link to="/patch-notes"><v-icon class="mr-2">mdi-update</v-icon>Patch notes</router-link>
                         </div>

diff --git a/resources/js/components/Home/PatchNotes.vue b/resources/js/components/Home/PatchNotes.vue
@@ -4,6 +4,36 @@
             Patch notes
         </div>
 
+        <v-card outlined class="rounded-lg mb-8">
+            <v-card-title>v0.13.3<v-spacer /> 2024.09.02.</v-card-title>
+            <v-card-text>
+                <b>Bug fixes:</b>
+                <ul>
+                    <li>Fixed a bug on the review page that prevented reviewing words and phrases that had no example sentences.</li>
+                </ul>
+            </v-card-text>
+        </v-card>
+
+        <v-card outlined class="rounded-lg mb-8">
+            <v-card-title>v0.13.2<v-spacer /> 2024.08.30.</v-card-title>
+            <v-card-text>
+                <b>Bug fixes:</b>
+                <ul>
+                    <li>Fixed website import.</li>
+                </ul>
+            </v-card-text>
+        </v-card>
+
+        <v-card outlined class="rounded-lg mb-8">
+            <v-card-title>v0.13.1<v-spacer /> 2024.08.29.</v-card-title>
+            <v-card-text>
+                <b>Bug fixes:</b>
+                <ul>
+                    <li>Turkish temporary fix.</li>
+                </ul>
+            </v-card-text>
+        </v-card>
+
         <v-card outlined class="rounded-lg mb-8">
             <v-card-title>v0.13<v-spacer /> 2024.06.24.</v-card-title>
             <v-card-text>

diff --git a/resources/js/components/Review/Review.vue b/resources/js/components/Review/Review.vue
@@ -534,7 +534,7 @@
                         '《', '》','【', '】', '『', '』', '〔', '〕', '［', '］', '・', '?', '(', ')', ' ', ' NEWLINE ', '.', '%', '-',
                         '«', '»', "'", '’', '–', 'NEWLINE'];
 
-                if (this.settings.reviewSentenceMode === 'disabled') {
+                if (this.settings.reviewSentenceMode === 'disabled' || this.exampleSentence === null) {
                     if (this.reviews[this.currentReviewIndex].type == 'word') {
                         this.readWords ++;
                     } else {
@@ -662,7 +662,7 @@
 
                 this.exampleSentence = null;
                 axios.get('/vocabulary/example-sentence/' + this.reviews[this.currentReviewIndex].type + '/' + this.reviews[this.currentReviewIndex].id).then((response) => {
-                    if (response.data !== 'no example sentence') {
+                    if (response.data.words !== undefined) {
                         this.exampleSentence = {
                             id: 0,
                             words: response.data.words,