Modify drag'n fill command behaviour to fix audreyt/ethercalc#769. #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelklehr
reviewed
Mar 17, 2022
| @@ -25090,6 +25064,8 @@ SocialCalc.SpreadsheetControlExecuteCommand = function(obj, combostr, sstr) { | |||
| var spreadsheet = SocialCalc.GetSpreadsheetControlObject(); | |||
| var eobj = spreadsheet.editor; | |||
|
|
|||
| console.log("SCEC : combostr : " + combostr + "\n\tsstr : " + sstr); // DEBUG STUFF | |||
There was a problem hiding this comment.
These probably should be removed
There was a problem hiding this comment.
Yes, I agree. How should I do this ? Push a new commit on top of this one or amend this one and force push or something else ?
|
I can't test this atm, so defer to @eddyparkinson's judgement :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
With this pull request I address two points :
Drag'n fill
I think I fix this issue : audreyt/ethercalc#769 by modifying the fillright and filldown command string to embed the increment amount.
My tests consists of running an ethercalc instance and using the fill command in all directions with one, two or more cells first selected.
It seems to me that this is good.
Gulp
I also update gulp package from 3 to 4, to use with newer nodejs.
So I had to adapt gulp.js.
This don't resolve the large warning flow nor the error as on master branch.