Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create the dialog object using a single function #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Create the dialog object using a single function #44

wants to merge 1 commit into from

Conversation

tintou
Copy link

@tintou tintou commented Feb 4, 2018

No description provided.

@eddyparkinson
Copy link
Collaborator

Thanks for this. I only had a quick look, will look more when I have time. How was it tested?

Thanks again.

@tintou
Copy link
Author

tintou commented Feb 5, 2018

I have a simple .html file to test socialcalc only. so I clicked on the three icons to test the dialogs

@eddyparkinson
Copy link
Collaborator

@marcelklehr do you have time to check and merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tintou @eddyparkinson