Source reorganisation #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #31 |
tintou
force-pushed
the
source-reorganisation
branch
from
9a5f232 to
e947563
Compare
|
Re-synced with master |
|
This one is probably safer to review than the lint changes |
eddyparkinson
approved these changes
Jan 10, 2018
marcelklehr
reviewed
Jan 10, 2018
| @@ -8,7 +8,7 @@ See it in action at [ethercalc.net](http://ethercalc.net)! | |||
| * jQuery (only on the client-side) | |||
|
|
|||
| ## Usage | |||
| You can `require('socialcalc')` or include `node_modules/socialcalc/SocialCalc.js` on your web page using a script tag. | |||
| You can `require('socialcalc')` or include `node_modules/socialcalc/dist/SocialCalc.js` on your web page using a script tag. | |||
There was a problem hiding this comment.
This will require updating EtherCalc, but looks good otherwise.
There was a problem hiding this comment.
True, would break this line - https://github.com/audreyt/ethercalc/blob/master/Makefile#L50
|
Pull request proposed in ethercalc audreyt/ethercalc#582 |
|
Requirement Ethercalc version 2018-01-12 requires these changes |
|
Ah, we missed package.json: https://github.com/marcelklehr/socialcalc/blob/master/package.json#L5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It depends on the gulp branch being merged