Merge pull request #60 from marcelblijleven/chore/cleanup

Chore/cleanup

.github/workflows/tests.yaml

@@ -36,7 +36,8 @@ jobs:
         run: hatch run test-cov
       - name: "Upload coverage to Codecov"
         if: matrix.python-version == 3.12  # Only upload coverage once per run
-        uses: codecov/codecov-action@v2
+        uses: codecov/codecov-action@v3
         with:
-          fail_ci_if_error: true
+          fail_ci_if_error: false
+
           token: ${{ secrets.CODECOV_TOKEN }}

Makefile

@@ -1,11 +1,4 @@
-.PHONY: all install clean_project
-
-all: clean_project install
-
-install:
-	pip install -r requirements_dev.txt
-	cp pre-commit.template .git/hooks/pre-commit
-	chmod +x .git/hooks/pre-commit
+.PHONY: clean_project
 
 clean_project:
 	find . \( -type f -name '*.pyc' -or -type d -name '__pycache__' \) -delete

pyproject.toml

@@ -47,11 +47,12 @@ dependencies = [
     "httpx",
     "coverage[toml]>=6.5",
     "pytest",
+    "pytest-cov",
     "pytest-mock>=3.10",
 ]
 [tool.hatch.envs.default.scripts]
 test = "pytest {args:tests}"
-test-cov = "coverage run -m pytest {args:tests}"
+test-cov = "coverage run -m pytest --cov {args:tests} "
 cov-report = [
     "- coverage combine",
     "coverage report",

src/adventofcode/year_2023/day_01_2023.py

@@ -25,6 +25,9 @@ def get_calibration_value(line: str) -> int:
             if left is None:
                 left = char
 
+    if left is None or right is None:
+        raise ValueError("invalid state")
+
     return int(left + right)
 
 
@@ -50,6 +53,9 @@ def get_calibration_value_with_words(line: str) -> int:
             right = value
             right_idx = rfind
 
+    if left is None or right is None:
+        raise ValueError("invalid state")
+
     return int(left + right)