Fix tap on polyline #2847
Open
Fix tap on polyline #2847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Probably the bug of the Google Maps SDK for Android v3 beta
wf9a5m75
reviewed
Dec 11, 2020
| @@ -102,12 +102,12 @@ -(void)create:(CDVInvokedUrlCommand *)command | |||
|
|
|||
| // Since this plugin provide own click detection, | |||
| // disable default clickable feature. | |||
| polyline.tappable = NO; | |||
| polyline.tappable = [[json valueForKey:@"clickable"] boolValue]; | |||
There was a problem hiding this comment.
This is wrong. If you set polyline.tappable = YES, this plugin can not get clicked latlng.
There was a problem hiding this comment.
I agree with you, but the code to try to find if the click is on the polyline don't work see my git project example in #2845
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to my issue -> #2845
I use the lib & possibility of google map sdk native plugin on ios.
When you have a lot of polylines in your map, the previous fonctionnality of this cordova plugin to try to calculate if click is on polyline don't work, so i use the native default functionnality with didtabOverlay event.
The only default of my solution is that i cannot find the position clicked by user, the google map sdk plugin don't give the position clicked. So i return the center of the clicked polyline.